[Feature Request] Configurable Emoji / PR Comment templates

[fbartho]

It's been years that I've been a fan and contributor to DangerJS, but one thing that always gives me a heart attack is the emoji in the DangerJS signature line -- because it sometimes renders in a clipped way in email Previews: note: that this sometimes gets shortened even more awkwardly

Is there any way to customize this emoji?

A. Would we object to a global change of it to something more neutral or less negatively interpreted? B. Would we object to a feature allowing people to override what it will be?

I haven't explored the code to see how hard this would be yet, as I first wanted input before submitting a PR.

Thanks for your thoughts!

[orta]

I don't want a million little config options, so no, I'd accept changing it to a :warn: because that is the danger JS icon though

[orta]

If you can think of a more compelling case for allowing custom message templates on the whole, that could work

[orta]

If you can think of a more compelling case for allowing custom message templates on the whole, that could work

[fbartho]

I could totally see uses for changing the whole template, but I don’t have a dying need for it. If others do, then I’d be happy to help implement.

For my own niggle, I can probably monkeypatch danger on install if I have a minute, but it probably doesn’t deserve me trying to change your mind.

thanks for the input and thoughts @orta!

[bytestream]

Not sure I've got the wrong issue, but I like the idea of customizable comment templates. I'd like to display markdown above the fail table rather than underneath everything. At the moment that doesn't seem to be possible.

[jviall]

I'd like this feature for a similar reason as @fbartho mentions. In notifications from Danger (PR comments / Emails), the red symbol gives a false signal. I'd love to be able to configure this so that what I'm reading in my notifications gives me a very quick glance at whether the ntofication deserves clicking or not.

If I could customize it based on the output of the danger run, I would change it to give brief counts of the various outputs, with an emoji that reflected the highest severity present, e.g.:

✅ 0 errors, 0 warnings, 1 comments found against ....
⚠️ 0 errors, 1 warnings, 2 comments found against ....
🚫 2 errors, 0 warnings, 1 comments found against ....

Without this feature, the notifications I receive from danger are mostly noise. At the very least, I'd appreciate being able to change the message to not have the 🚫 emoji so I can avoid having my cortisol raised slightly every time danger outputs a perfectly healthy run 😅