pylcdsysinfo icon indicating copy to clipboard operation
pylcdsysinfo copied to clipboard

Updating to modernized tooling and dependencies

Open greylurk opened this issue 3 years ago • 5 comments

This is a first draft of moving to python3, pyusb 1.1.1, and pillow 8.1.0 instead of PIL

I don't know if this is still under any sort of active development, but I dug my ColdTears out of mothballs and decided I wanted to do something with it, so this is the result of an afternoon of cleanup and refactoring.

greylurk avatar Feb 09 '21 21:02 greylurk

Interesting, I just did the same thing yesterday! I managed to get @mattyribbo fork working locally on RasPi 400 but I wasn't able to install as a module, just use it locally. I'll take a look at this, thanks! (and thanks @clach04 for the pointer to this PR which I somehow had missed)

andypiper avatar Feb 13 '21 18:02 andypiper

If you're planning on continuing with active dev here, I can see a lot of opportunities to fix up the README (since ColdTears wiki went away); improve the samples; etc. Would love to see a Python 3 version installable from PyPI. Will help if I can.

andypiper avatar Feb 13 '21 20:02 andypiper

Thanks for doing this @greylurk, looks good to me 👍

I'm still using my device (its a clock, showing local Air Quality readings and disk space - not a common combination of things to want to show at the same time 😆) and being able to move to Py3 is going to be handy (all my other services are py3). Nice job sorting out dependencies.

@andypiper for now, in the off-chance you were not aware, you can pip install from a github url/branch

clach04 avatar Feb 13 '21 22:02 clach04

I just merged this branch with the advanced drawing code by MrBrax (see https://github.com/clach04/pylcdsysinfo/tree/py3_modern_pillow_drawing) its 100% untested (not near my device to test, there may be some py2 remnants).

clach04 avatar Feb 13 '21 22:02 clach04

Most of the advanced examples in that case (which look interesting, since they provide much better drawing and text options) rely on the lcd_drawing code which hasn't had the same pyusb-1.1 updates. I've had a play but I'm still seeing a number of type errors. I think there's definitely a good opportunity to combine efforts and revitalise this!

andypiper avatar Feb 13 '21 22:02 andypiper