plantcv icon indicating copy to clipboard operation
plantcv copied to clipboard

Update report size marker objects class

Open HaleySchuhl opened this issue 2 years ago • 1 comments

Describe your changes Update pcv.report_size_marker input parameters to take new roi formatted Object.

Type of update Is this a:

  • update

Associated issues #945

Additional context Add any other context about the problem here.

For the reviewer See this page for instructions on how to review the pull request.

  • [ ] PR functionality reviewed in a Jupyter Notebook
  • [x] All tests pass
  • [x] Test coverage remains 100%
  • [ ] Documentation tested
  • [x] New documentation pages added to plantcv/mkdocs.yml
  • [x] Changes to function input/output signatures added to updating.md
  • [ ] Code reviewed
  • [ ] PR approved

HaleySchuhl avatar Sep 14 '22 17:09 HaleySchuhl

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-4.0@3129d85). Click here to learn what that means. The diff coverage is 100.00%.

:exclamation: Current head eda1f1a differs from pull request most recent head d47b063. Consider uploading reports for the commit d47b063 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             release-4.0     #955   +/-   ##
==============================================
  Coverage               ?   99.98%           
==============================================
  Files                  ?      161           
  Lines                  ?     6849           
  Branches               ?        0           
==============================================
  Hits                   ?     6848           
  Misses                 ?        1           
  Partials               ?        0           
Flag Coverage Δ
unittests 99.98% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/report_size_marker_area.py 100.00% <100.00%> (ø)

codecov[bot] avatar Sep 14 '22 17:09 codecov[bot]