plantcv icon indicating copy to clipboard operation
plantcv copied to clipboard

standard color correction matrix function

Open JorgeGtz opened this issue 2 years ago • 1 comments

Describe your changes Add a function that helps us access the standard rgb values (hard coded) for the chips in the color cards. This allow us to correct images with respect to the std values.

Source: https://en.wikipedia.org/wiki/ColorChecker

Type of update Is this a:

  • New feature or feature enhancement
  • Work in progress

Associated issues Reference associated issue numbers. Does this pull request close any issues?

Additional context Add any other context about the problem here.

For the reviewer See this page for instructions on how to review the pull request.

  • [ ] PR functionality reviewed in a Jupyter Notebook
  • [ ] All tests pass
  • [ ] Test coverage remains 100%
  • [ ] Documentation tested
  • [ ] New documentation pages added to plantcv/mkdocs.yml
  • [ ] Changes to function input/output signatures added to updating.md
  • [ ] Code reviewed
  • [ ] PR approved

JorgeGtz avatar Aug 04 '22 21:08 JorgeGtz

Codecov Report

Merging #931 (6595840) into release-4.0 (bf2093c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0      #931   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              161       161           
  Lines             6844      6859   +15     
=============================================
+ Hits              6844      6859   +15     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/transform/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/transform/color_correction.py 100.00% <100.00%> (ø)

codecov[bot] avatar Aug 04 '22 21:08 codecov[bot]