plantcv icon indicating copy to clipboard operation
plantcv copied to clipboard

Adding camera calibration tutorial

Open annacasto opened this issue 10 months ago • 2 comments

Describe your changes Added a tutorial for the checkerboard calibration and camera calibration functions.

Type of update Is this a:

  • Update to documentation

Associated issues Reference associated issue numbers. Does this pull request close any issues?

Additional context Add any other context about the problem here.

For the reviewer See this page for instructions on how to review the pull request.

  • [ ] PR functionality reviewed in a Jupyter Notebook
  • [x] All tests pass
  • [x] Test coverage remains 100%
  • [x] Documentation tested
  • [ ] New documentation pages added to plantcv/mkdocs.yml
  • [ ] Changes to function input/output signatures added to updating.md
  • [x] Code reviewed
  • [x] PR approved

annacasto avatar Apr 25 '24 16:04 annacasto

Here's the code health analysis summary for commits 1d16aab..cd47354. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

deepsource-io[bot] avatar Apr 25 '24 16:04 deepsource-io[bot]

Thanks! I fixed typos and added a line about minimum checkerboard size.

annacasto avatar Apr 26 '24 16:04 annacasto

Looks great, could we add the GitHub and Colab buttons here like we started doing on the newer tutorials? Example here: https://plantcv.readthedocs.io/en/latest/tutorials/kmeans_clustering_tutorial/

nfahlgren avatar May 14 '24 18:05 nfahlgren

Just added those new buttons!

annacasto avatar May 16 '24 16:05 annacasto