plantcv
plantcv copied to clipboard
Update watershed.py to make the function return `labels`
For context please see... Associated issues
- #1481
For the reviewer See this page for instructions on how to review the pull request.
- [ ] PR functionality reviewed in a Jupyter Notebook
- [ ] All tests pass
- [ ] Test coverage remains 100%
- [ ] Documentation tested
- [ ] New documentation pages added to
plantcv/mkdocs.yml
- [ ] Changes to function input/output signatures added to
updating.md
- [ ] Code reviewed
- [ ] PR approved
Here's the code health analysis summary for commits 15a580d..c415bc1
. View details on DeepSource ↗.
Analysis Summary
Analyzer | Status | Summary | Link |
---|---|---|---|
✅ Success | View Check ↗ | ||
✅ Success | View Check ↗ |
Code Coverage Report
Metric | Aggregate | Python |
---|---|---|
Branch Coverage | 100% | 100% |
Composite Coverage | 99.7% | 99.7% |
Line Coverage | 99.7% | 99.7% |
New Branch Coverage | 100% | 100% |
New Composite Coverage | 100% | 100% |
New Line Coverage | 100%, ✅ Above Threshold | 100%, ✅ Above Threshold |
💡 If you’re a repository administrator, you can configure the quality gates from the settings.
Updated debug image so will update example in docs page tomorrow probably
Just one comment before approving: I don't think the documentation makes it clear how the labels are/can be used or accessed. For example, it says "These data can always get accessed during a workflow (example below)" but the labels are not accessed in the example. Maybe this is better demonstrated by a tutorial, but I think a small example in the documentation page could help illustrate the functionality.
Just one comment before approving: I don't think the documentation makes it clear how the labels are/can be used or accessed. For example, it says "These data can always get accessed during a workflow (example below)" but the labels are not accessed in the example. Maybe this is better demonstrated by a tutorial, but I think a small example in the documentation page could help illustrate the functionality.
Good point, just added~~ Thanks Anna!