plantcv icon indicating copy to clipboard operation
plantcv copied to clipboard

Update watershed.py to make the function return `labels`

Open HaleySchuhl opened this issue 11 months ago • 2 comments

For context please see... Associated issues

  • #1481

For the reviewer See this page for instructions on how to review the pull request.

  • [ ] PR functionality reviewed in a Jupyter Notebook
  • [ ] All tests pass
  • [ ] Test coverage remains 100%
  • [ ] Documentation tested
  • [ ] New documentation pages added to plantcv/mkdocs.yml
  • [ ] Changes to function input/output signatures added to updating.md
  • [ ] Code reviewed
  • [ ] PR approved

HaleySchuhl avatar Mar 21 '24 15:03 HaleySchuhl

Here's the code health analysis summary for commits 15a580d..c415bc1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

deepsource-io[bot] avatar Mar 21 '24 15:03 deepsource-io[bot]

Updated debug image so will update example in docs page tomorrow probably

HaleySchuhl avatar Apr 24 '24 20:04 HaleySchuhl

Just one comment before approving: I don't think the documentation makes it clear how the labels are/can be used or accessed. For example, it says "These data can always get accessed during a workflow (example below)" but the labels are not accessed in the example. Maybe this is better demonstrated by a tutorial, but I think a small example in the documentation page could help illustrate the functionality.

annacasto avatar May 13 '24 16:05 annacasto

Just one comment before approving: I don't think the documentation makes it clear how the labels are/can be used or accessed. For example, it says "These data can always get accessed during a workflow (example below)" but the labels are not accessed in the example. Maybe this is better demonstrated by a tutorial, but I think a small example in the documentation page could help illustrate the functionality.

Good point, just added~~ Thanks Anna!

HaleySchuhl avatar May 13 '24 20:05 HaleySchuhl