plantcv icon indicating copy to clipboard operation
plantcv copied to clipboard

Removing mutable default arguments

Open natejly opened this issue 1 year ago • 3 comments

Describe your changes Removing mutable default arguments Balanced tuple unpacking from other Deepsource warning Added a test case to test_hyper_histogram.py

Type of update Deepsource issues

For the reviewer See this page for instructions on how to review the pull request.

  • [ ] PR functionality reviewed in a Jupyter Notebook
  • [ ] All tests pass
  • [ ] Test coverage remains 100%
  • [ ] Documentation tested
  • [ ] New documentation pages added to plantcv/mkdocs.yml
  • [ ] Changes to function input/output signatures added to updating.md
  • [ ] Code reviewed
  • [ ] PR approved

natejly avatar Feb 15 '24 17:02 natejly

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (84309ac) 99.98% compared to head (e7a4de6) 99.98%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1456   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         158      158           
  Lines        6983     6987    +4     
=======================================
+ Hits         6982     6986    +4     
  Misses          1        1           
Flag Coverage Δ
unittests 99.98% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/plantcv/transform/color_correction.py 100.00% <100.00%> (ø)
plantcv/plantcv/visualize/hyper_histogram.py 100.00% <100.00%> (ø)

codecov[bot] avatar Feb 15 '24 17:02 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (84309ac) to head (e7a4de6). Report is 149 commits behind head on main.

:exclamation: Current head e7a4de6 differs from pull request most recent head c9ab379. Consider uploading reports for the commit c9ab379 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1456   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         158      158           
  Lines        6983     6987    +4     
=======================================
+ Hits         6982     6986    +4     
  Misses          1        1           
Flag Coverage Δ
unittests 99.98% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/plantcv/transform/color_correction.py 100.00% <100.00%> (ø)
plantcv/plantcv/visualize/hyper_histogram.py 100.00% <100.00%> (ø)

codecov-commenter avatar Mar 03 '24 01:03 codecov-commenter

Here's the code health analysis summary for commits f8c686f..47f7a0f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 5 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage94%94%
Line Coverage94%94%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

deepsource-io[bot] avatar Mar 03 '24 01:03 deepsource-io[bot]