openhtmltopdf icon indicating copy to clipboard operation
openhtmltopdf copied to clipboard

#399 #416 Initial fix for header/footer showing on page without body rows

Open danfickle opened this issue 6 years ago • 6 comments

I also plan to add some commits to this PR with general table cleanup of code.

@VictorAtPL, if you get time, you could perhaps test this branch with your real world tables.

danfickle avatar Nov 23 '19 05:11 danfickle

The test I just committed for #202 still produces this:

issue-202-malformed-table

so clearly there is still more related problems in the table code.

danfickle avatar Nov 23 '19 07:11 danfickle

Right now it works differently. It puts part of text on the previous page, and part of it on the next, even that I have:

div.parts table.part tr, div.parts table.part tr td {
    page-break-inside: avoid;
}

in the styles. openhtmltopdf_result_after_authors_bugfix

VictorAtPL avatar Nov 23 '19 14:11 VictorAtPL

@danfickle Hi, any update when this will be ready to be released? I'm hopeful it will fix the issues i'm experiencing.

leedsalex avatar Jan 16 '20 22:01 leedsalex

@VictorAtPL, it is not clear from your comment if this is a problem introduced in this pr or was already existing? If it was already existing I propose to merge this pr and do a release, then we can work more on table rendering in a different pr.

@leedsalex Very soon if this pr has not introduced any additional problems as above.

danfickle avatar Jan 17 '20 03:01 danfickle

@danfickle I will test it tomorrow and answer your question.

VictorAtPL avatar Jan 20 '20 23:01 VictorAtPL

Hi @VictorAtPL, I'm back finally. I had a play around but wasn't able to replicate. Are you able to share how the left blue arrow bar is achieved? At a guess it involves rowspan, transforms and a CSS arrow? Even better would be a sample.

danfickle avatar Feb 20 '20 12:02 danfickle