Daniel Fernandes
Daniel Fernandes
The colors get toggled properly now, but there is one thing left: the key column view needs to be refreshed when the setting is toggled. Otherwise the user has to...
> I see that both the new color state and s_bpmColumnPrecision are applied in the next paint event, which happens for me when I close the preferences and see the...
> What do you think? Should we have the enable switch in the Library page, and the future palette config in Colors? If we add key color support to the...
Thank you @daschuer, @ronso0 and @Swiftb0y for your feedback so far! I think I'm ready for a final review. I was thinking of cleaning up the git log a little,...
I want to work on adding the key color palettes. I'm a bit unsure which branch to do it on. Should I branch off from this PR's branch, and then...
Got it, thank you.
Thank you for the review. I have used the enum comparison now, and placed all the text/color rendering code inside this condition. Let me know when it is the right...
> not perfect, but good enough considering the status quo. I appreciate the honest feedback. Can you please tell me in what aspects I can improve?
Thank you for your input! You're right, this one assumes that keylock is kept off. It was the initial idea. To handle other workflows, we were thinking of having a...
Yes! Here it is: https://gist.github.com/danferns/d35e6980b70b7901b791e38971401835