Daniel Tschinder comments

Results 175 comments of


                                            Daniel Tschinder

Discussion eslint rule `fp/no-loops`

It looks like we can move forward with this.

Discussion: remove a lot of opinionated rules

I am totally for this.

Discussing rule: max-lines-per-function

I think especially that prettier has the hand over most of the styling, sometimes it is also out of our hands to "fix" this rule. like ```ts const {a,b,c,d,f,g} =...

Jade renamed to Pug

I think we should deprecate this package, as pug now supports jstransforms and there is already one for babel: https://github.com/jstransformers/jstransformer-babel

Disabled tabs should remain keyboard focusable as per W3C WAI ARIA guidelines

Love that you want to work on this. It would be ideal if the visual state could stay close to what it is right now.

Selected tab has no css applied

Could you create an example for this problem? Because I cannot reproduce this on https://reactcommunity.org/react-tabs/

Selected tab has no css applied

Good catch! The `:after` class was used to hide the outline when selecting the tab. But since the last major version this outline was removed anyway, so also this `:after`...

false warning about "'Tab' outside 'TabList'" when using Immutable seq

That is not react-tabs you are importing?

false warning about "'Tab' outside 'TabList'" when using Immutable seq

I think it is beacuse seqKey().map() returns not an array but an immutable data structure, and the propTypes check seems to not account for this. I will check this.

styled-components don't work with Tab.js

This is fixed in 2.0.0 and should work out of the box now