daneren2005
Fixed Sharing feature from returning incorrect URL
Remove any URL reformatting as Airsonic returns it properly. Should be tested with Subsonic.
Issue Reference: #978
This check must have been in for a reason, therefore it may be possible that it breaks sharing on some Subsonic/Airsonic servers
In particular, this commit to libresonic (released v6.2.1) seems to have changed how share names were created: https://github.com/airsonic/airsonic/commit/f7bd43136b6275de1206fd6be500f2961e0e6623 Subsonic introduced the Share feature in Subsonic REST API v1.6.0. Example: http://www.subsonic.org/pages/inc/api/examples/shares_example_1.xml
That said, I am running this fine with Airsonic-Advanced 11.0.0-SNAPSHOT.20220625052932 and subsonic-rest-api v1.15.
Unfortunately, I do not have a Subsonic server up and running to test from and I could not find any identifying ways to determine if DSub is connected to an Subsonic or Airsonic server (methods I found reported ServerInfo.isStockSubsonic() to true), only what subsonic-rest-api I was dealing with (v1.15). I would love to know if Subsonic is returning the same long URL as it does in the 1.6.0 example or is returning the same values that we see here with Airsonic.
This might be something that needs to be looked into on the Airsonic server side if Subsonic is offering the short URL for shares. Either this code was warranted and people do not use the share function through DSub or one side (client/server) is providing inconsistent results. Any help with testing this would be very welcome.
I have uploaded a build to my fork for testing: https://github.com/mwielgosz/Subsonic/releases/tag/5.5.3-share-fix This will require that you UNINSTALL your old DSub app as they are not signed with the same keystores.
Hi, I just opened a topic on the same problem, and if useful it can be merged with this one. I don't understand if the problem has been fixed cos im'running on my phone dsub 5.5.1 and the problem still exist. Have i to do a particular workaround?
Not sure why this has not been reviewed or responded to yet...possibly due to it not being a largely reported issue (and a small one at that). That said, hopefully this fork will help whoever finds it nullify the frustrating sharing issue.