David Negstad
David Negstad
Unfortunately Aspire on Windows currently assumes either a Docker or Podman Desktop install scenario where the container CLI will handle automatically remapping Windows file paths for the daemon in WSL....
One thing I haven't done in this PR is account for the case where only a subset of the available network pools may be able to fulfill the given preferred...
I ended up adding a step to sort the pools if a preferred size is specified (with the idea being to prefer pools that are able to accommodate the preferred...
> Just found a previous PR/discussion related to address pool sizes. So, linking it here, but it looks like that work stalled in April last year ... > > *...
I'm suspicious there'll still be a few changes warranted to this PR, but I think it's at a place where it's at ready for actual review.
> > but it looks like that work stalled in April last year ... > > Author of #47737 here, I was not given clear instructions or guidance on the...
> [We discussed this PR during today's libnet maintainers call. > > We all agreed that the `--subnet`-based UX is better than forcing users to specify an `--ipam-opt`. > >...
@akerouanton with the latest commits, I believe the PR is at a place where it matches the desired behavior.
I missed a unit test that was validating RequestPool with "all address" subnet requests (`0.0.0.0/x`, `::/x`) and expecting the previous behavior (try to process it as an explicit subnet request)....
> Could you squash your commits please? It'd make it easier to review from an IDE. At a quick glance, I think there's no upfront refactoring, so it should probably...