publishing-python-packages icon indicating copy to clipboard operation
publishing-python-packages copied to clipboard

:bug: action trigger on manuel release on GitHub UI

Open enryH opened this issue 9 months ago • 3 comments

  • workflow was not triggered if the instruction on p. 124f were followed

Description of issue

Following the instructions in the book, the GitHub actions were not triggered.

Description of solution

Add release triggers as described here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

enryH avatar Sep 06 '23 16:09 enryH

So this alone did not do the trick. I think the event ref just does not exist anymore, so the conditional startsWith needs to be changed additionally

enryH avatar Sep 07 '23 14:09 enryH

@enryH thank you for reporting this! Unfortunately this repository needs to remain static to align with the content in the book; I have suggested that I might create a living version that changes with the times (and only has one package, rather than several chapters' iterations on a package). That would be the place to fix this, to be sure. I'll leave this open and get back to you when that happens?

daneah avatar Sep 08 '23 18:09 daneah

Hey! A live version of the repository would be great. Maybe you could test the pip package upload once a month using calendar versioning?

enryH avatar Sep 13 '23 19:09 enryH