iterm-components icon indicating copy to clipboard operation
iterm-components copied to clipboard

GitHub Stars fails with a knobs error

Open andypiper opened this issue 4 years ago • 4 comments

When the component is added to the status bar and configured, a ladybug shows in the status bar. Clicking returns this error:

Status bar component “GitHub stars” (engineering.dane.iterm-components.github-stars) failed.

This function call had an error:

statusbar.engineering.dane.iterm_components.github_stars.github_stars_coroutine(knobs:__knobs)

The error was:

Reference to undefined variable “__knobs”. Change it to “__knobs?” to treat the undefined value as null.

I think something has changed with the way this variable is scoped, maybe?

andypiper avatar Nov 16 '20 13:11 andypiper

Thanks for the report @andypiper—it's possible the API has changed since I last worked on this! I'll see if I have some time this week to look. If you get curious and find a fix, I'd be happy to accept a pull request as well 😄

daneah avatar Nov 16 '20 14:11 daneah

I've been playing with it on-and-off for a while since I based one of my own scripts on yours :-) but I've not worked it out yet. I've been on the verge of heading to the iTerm mailing list for advice, but haven't had the time.

andypiper avatar Nov 17 '20 12:11 andypiper

Hi guys, any news on it?
I'm trying to get the knob value in the click callback without success...

DiegoGiovany avatar Sep 08 '21 18:09 DiegoGiovany

Hey @DiegoGiovany, unfortunately this project isn't really in much active development these days—I don't even really use the iTerm components feature on a day-to-day basis at present. I definitely don't have bandwidth right now but could try to take a look in, realistically, the next few months.

daneah avatar Sep 08 '21 18:09 daneah