envsub icon indicating copy to clipboard operation
envsub copied to clipboard

Fix when hash is inner a value of a variable that escaped by quote

Open bosure19 opened this issue 4 years ago • 4 comments

I found an issue in case of MYVAR="anyvalue#anyvalue" will be compute to "anyvalue instead of anyvalue#anyvalue. so we can't escape hash character

bosure19 avatar Jan 09 '20 16:01 bosure19

Coverage Status

Coverage remained the same at 100.0% when pulling 8212d443f39e0f98f5a7462456d4eab61d027411 on bosure19:bugfix/escape-hash-on-quote into f699d032bb2413f159ffaf99113a7c8926704d22 on danday74:master.

coveralls avatar Jan 09 '20 16:01 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling 33bf94aba6ada58fa7b2c99736e6ff01f619f659 on bosure19:bugfix/escape-hash-on-quote into f699d032bb2413f159ffaf99113a7c8926704d22 on danday74:master.

coveralls avatar Jan 09 '20 16:01 coveralls

@danday74 Any chance we get this merged ?

toniopelo avatar Feb 05 '24 17:02 toniopelo

OK the conflict seems fairly easy to resolve and coverage remains at 100%

But merging this won't publish it to npm

I haven't got time to publish to npm

If you give me your npm username then I can add you as a collaborator on npm and you can publish it yourself

Let me know if that works for you, if so I'll merge it

danday74 avatar Feb 06 '24 10:02 danday74