memmap-rs icon indicating copy to clipboard operation
memmap-rs copied to clipboard

Is this crate still maintained?

Open fogti opened this issue 6 years ago • 15 comments

It seems like this crate wasn't really (well?) maintained since October 2018. Last commit was https://github.com/danburkert/memmap-rs/commit/3b047cc2b04558d8a1de3933be5f573c74bc8e0f (18 Apr 2018) and last release was memmap v0.7.0 (20 Sep 2018).

fogti avatar Oct 03 '19 19:10 fogti

Hi @danburkert!

I was just perusing through various repositories involving implementations of memory-mapping in Rust, and, in the process, I happened to come across both this issue and https://github.com/rbranson/rust-mmap/issues/5, which made me smile. 😁

Are you still planning on handling the open issues and PRs? Just a friendly ping! 🏓

spl avatar Feb 20 '20 13:02 spl

Since this crate has been flagged as unmaintained by RustSec, depending on it will fail builds for cargo audit CI users. There has been some forking already, but AFAICT, it is not for essential reasons.

If the maintainer(s) of this crate would like some community support, I'd be happy to volunteer. I appreciate the work already invested in it.

(cc @BurntSushi, who appears to be a co-maintainer)

ranweiler avatar Dec 02 '20 20:12 ranweiler

@RazrFalcon started a fork and released it on crates.io as memmap2, might also be a good option.

djc avatar Dec 02 '20 20:12 djc

@ranweiler My fork is maintained, but it doesn't really have any major changes.

RazrFalcon avatar Dec 02 '20 20:12 RazrFalcon

Thanks, @djc and @RazrFalcon. As a courtesy, I'd like to give this crate's maintainer(s) time to respond.

That said, IMO it's important for the community to have a nice wrapper around memory mapping. If there's no update in say, a week, or if this crate is explicitly abandoned, my offer extends to memmap2! FWIW, I don't need any particular PRs to land, or API changes. I just want to help keep the garden tended.

ranweiler avatar Dec 02 '20 20:12 ranweiler

I asked @danburkert a while back for commit access with the intent to try and pick up the maintenance for this crate. He graciously gave it to me, but sadly, I just haven't had the time to commit to it. So I wouldn't consider myself a co-maintainer at this point, and defer to @danburkert for whether to add new maintainers or not. (For my projects, I generally just prefer for someone to fork and carry it forward that way.)

BurntSushi avatar Dec 03 '20 00:12 BurntSushi

Understood, thanks for the update @BurntSushi!

ranweiler avatar Dec 03 '20 01:12 ranweiler

There's also mapr forked by Filecoin. I wonder whether they will be willing to maintain that crate @dignifiedquire?

niamster avatar Feb 23 '21 13:02 niamster

@RazrFalcon if you are willing to maintain memmap2 do you mind to copy current issues?

niamster avatar Feb 23 '21 14:02 niamster

@niamster Patches are welcome, but I don't plan on implementing them myself in the near feature.

RazrFalcon avatar Feb 23 '21 19:02 RazrFalcon

Thanks @RazrFalcon for your reply. I think that's fine as long as you accept patches and find people that can help. The first step would be migrate current issues. Looks like @ranweiler and myself might be first candidates to help you with that. @BurntSushi what do you think?

niamster avatar Feb 23 '21 19:02 niamster

we need to maintain our fork anyway, so I am happy to keep doing that. might not have time to add features, but patches and security fixes would be definitely happening

dignifiedquire avatar Feb 23 '21 19:02 dignifiedquire

I am also happy to join forces, so we can all enjoy a better crate

dignifiedquire avatar Feb 23 '21 19:02 dignifiedquire

@dignifiedquire thank you for your answer. May I ask why do you need to maintain your fork?

niamster avatar Feb 24 '21 01:02 niamster

Shouldn't this repository be archived and pointing to memmap2 in the readme?

oriongonza avatar Oct 24 '23 11:10 oriongonza