When redrawing the sample firstNameusingWordPreset, word placing don't avoid collision

[spapin]

Using Processing 2 on mac os,

when clicking on the outputwindow, the wordcram is redrawn, however some names are placed on top of each other.

I assume this is related to the instanciation of WordCram:

wc = new WordCram(this);

I believe the "this" passed as argument keeps artifact values that disrupt the new wordcram.

[spapin]

Update on this issue: the problem is related to the fact that the Word array used for two subsequent WordCram is the same.

However, the class Word holds memory of some information related to the WordCram the word was involved in.

For instance, once a word is skipped for the first time, the attribute

Word.skippedBecause

is set to a value explaining why the word was skip. Upon drawing a new WordCram, this skippedReason persists. The piece of code handling word collision will do the following:

        boolean foundOverlap = false;
        for (int i = 0; !foundOverlap && i < eWordIndex; i++) {
            EngineWord otherWord = eWords[i];
            if (otherWord.wasSkipped()) continue; //can't overlap with skipped word

            if (eWord.overlaps(otherWord)) {
                foundOverlap = true;
                lastCollidedWith = otherWord;
            }
        }

        if (!foundOverlap) {
            eWord.finalizeLocation();
            return true;
        }

Here, the otherword may have been skipped in a previous wordcram: collision detection will not apply.

The proposed fix is to delegate the skipped/not skipped property to the WordCram class.

[danbernier]

Yeah, you can't re-use a WordCram instance for another drawing - it's easier to just make a new one.

This does mean that you'll have to re-parse the text, but that's usually not too time-consuming, compared to the layout.