Dana Jansens comments

Results 191 comments of


                                            Dana Jansens

Iterator::collect should ideally support conversions #425

Haven't heard anything in a bit here, will you be coming back to it?

Flesh out the Vec and Slice APIs and implementations

Slice is done in https://github.com/chromium/subspace/pull/218 Vec remains

sus::dyn() without an explicit template parameter?

The code in the compiler explorer just in case: ```cpp #include #include #include #include template concept TypeErasedConceptOfConcreteType = requires { { DynC::template SatisfiesConcept } -> std::same_as; typename DynC::template DynTyped; requires...

How do we indicate that functions should be callable during compilation?

I would like to bring up a big issue with the `consteval` model in C++20. I attempted to properly describe it here: https://github.com/chromium/subspace/issues/266#issuecomment-1595810173 The tl;dr is that type_traits run at...

Invoke `backtrace-rs`' buildscript in `std`'s buildscript for Android targets

By adding a dependency on `cc` to the standard library, ~this~ https://github.com/rust-lang/rust/pull/116318 greatly complicates the lives of projects which build the standard library in our own build systems (Blueprint, GN,...

2.16

The addresses need to be updated.

2.16

There's a great explanation here https://github.com/SG57/Target-Percentage-Overlay/issues/1

Allow the library consumer to specify the Android API level

Wow it finally merged! I am about to go on vacation though, unlucky. If there's no rush I will address this after I am back. (Feel free to steal the...

build passes invalid `-nologo` and `-out:` flags to `ar` tool if specified in `AR` env var.

Here's the stdout of the full build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8795327228707936417/+/u/package_rust/stdout And of interest this part: ``` error: failed to run custom build command for `lzma-sys v0.1.17` Caused by: process didn't exit successfully:...

build passes invalid `-nologo` and `-out:` flags to `ar` tool if specified in `AR` env var.

Hans pointed out on the Chromium CL linked above that using `llvm-ar` on Windows is probably wrong, and indeed I see this code will choose `llvm-lib` on clang-cl/windows. And I...