opsin icon indicating copy to clipboard operation
opsin copied to clipboard

Make space after semi-colon optional

Open johnmay opened this issue 2 years ago • 3 comments

Some salt names use a semi-colon to indicate the salt. OPSIN supports this is but only as "; "

Example name

(2S,4R)-1-[(2S)-2-amino-3,3-dimethyl-butanoyl]-4-hydroxy-N-[[4-(4-methylthiazol-5-yl)phenyl]methyl]pyrrolidine-2-carboxamide;hydrochloride

johnmay avatar Nov 27 '23 06:11 johnmay

; is implemented in a really weird way (it's fudged as a space). I think it should be simple enough to support semicolon more like how space/hyphen are allowed as delimiters between words. I should have time to finish testing the fix later this week.

dan2097 avatar Nov 29 '23 02:11 dan2097

No rush, I fudge it in the reaction extractor anyways :-). Just thought a useful addition/relaxation.

johnmay avatar Nov 29 '23 09:11 johnmay

No rush, I fudge it in the reaction extractor anyways :-). Just thought a useful addition/relaxation.

Yeah I think it's definitely a good idea. My initial idea of treating this identically to space/hyphen was too simplistic as while say benzene;toluene is probably fine I don't think ethyl;benzene should be interpreted as ethylbenzene

dan2097 avatar Dec 03 '23 22:12 dan2097