ComputerCraft icon indicating copy to clipboard operation
ComputerCraft copied to clipboard

Change speakers to use the SPacketCustomSound packet instead

Open SquidDev opened this issue 5 years ago • 2 comments

The method to register new SoundEvents is private, which means that few (if any) mods actually register them. Consequently, one could not use the speaker to play any modded sound, as they weren't registered on the server side.

Using SPacketCustomSound does mean we can no longer determine if a sound exists or not, but I think a price I'm willing to pay in order to allow playing modded sounds.

SquidDev avatar Oct 10 '18 07:10 SquidDev

What happens if I try to play a sound that doesn't exist?

Lupus590 avatar Oct 10 '18 18:10 Lupus590

It just returns true and does nothing on the client.

SquidDev avatar Oct 10 '18 18:10 SquidDev