gas-mock-globals icon indicating copy to clipboard operation
gas-mock-globals copied to clipboard

Rewriting the codebase to TS

Open joshsny opened this issue 3 years ago • 3 comments

This pull request rewrites the codebase to typescript.

  • [x] Change all files from .js to .ts
  • [x] Convert imports and exports to Typescript style
  • [x] Add any type annotations to classes
  • [ ] Add correct type annotations to classes
  • [x] Ensure all tests run correctly

joshsny avatar Nov 09 '21 09:11 joshsny

Cool, I'll look intro it later today

jsarafajr avatar Nov 09 '21 09:11 jsarafajr

@jsarafajr Nevermind, I forgot to change it from a .js to .ts file 🤦All tests are passing now.

Still not sure about typing the global exports correctly. Any help would be appreciated for that, I'm not familiar with the global.variable export pattern and declaring global types.

joshsny avatar Nov 09 '21 09:11 joshsny

I have fixed the type errors I could find and all tests are passing. Haven't added any new tests since I have not added any functionality.

The global exports still need fixing and I am not sure how to do them, so will appreciate your help @jsarafajr :)

joshsny avatar Nov 09 '21 10:11 joshsny