dan-da
dan-da
comments?
Hi, thanks for contributing! To submit your pull request, you should first fork cdc_audit into your own repo and commit your changes there. Usually you should create a unique branch...
Also, it sounds like the schema support and the snapshot query are distinct features. If at all possible, it would be best to put these into two separate branches and...
Well, maybe that's the way. Just so long as its consistent for xpub, ypub, zpub is my hope....
ok, so what to use in place of them? maybe an example?? It's late at night here and code not in front of me, I'm probably missing something obvious. :-)
I think that would be an improvement, yes. regarding m/M... `m` is for xprv, and `M` is for xpub, yes? [source](https://en.bitcoin.it/wiki/BIP_0032#The_key_tree) Do any wallets actually enforce that? In my wanderings,...
yeah, so I notice that decodeAbsolute() supports `m` and `M`, but does not distinguish between them. should it? eg, disallow `M` for xprv?
ah, so the caller can decide. That seems better. I didn't look at it closely enough. Are you planning to merge the changes in [above comment](https://github.com/Bit-Wasp/bitcoin-php/issues/850#issuecomment-641602273) soon?
Sounds like you have a good handle on it. Flexibility is nice, and also defaulting to "the expected thing" for the most common case.