damus icon indicating copy to clipboard operation
damus copied to clipboard

Quotes

Open ericholguin opened this issue 2 years ago • 2 comments

This PR changes the boost/repost button from an alert to a sheet presentation, which shows the option to repost or quote a note. Repost works the same. Pressing the quote button presents the user with a post view sheet with the note id already inside.

The Relays view was also improved slightly to use the new half sheet and use the accent color on the participants text so its more obvious that it is "tap-able"

NOTE: This could be improved to actually show the embedded note and move the text cursor.

quotes

ericholguin avatar Feb 18 '23 22:02 ericholguin

quote note should be a new kind, not the note ref hack that people use today. I was thinking kind 66, with content as the note and then the note you're quoting is json encoded in a tag

jb55 avatar Feb 19 '23 16:02 jb55

Should it be a new kind? Can't it be a kind 1 with tags? Nip 01 mentions this:

This NIP defines "p" — meaning "pubkey", which points to a pubkey of someone that is referred to in the event —, and "e" — meaning "event", which points to the id of an event this event is quoting, replying to or referring to somehow.

ericholguin avatar Feb 24 '23 22:02 ericholguin

Closing - I need to do a refactor and take a different approach

ericholguin avatar Mar 24 '23 00:03 ericholguin