damus
damus copied to clipboard
Add menu ellipsis button to notes
This PR replaces the context menu (long press on notes) with a menu button, shown as ellipsis, on each note. This will allow for other long press gestures on notes while still allowing users to access the context menu.
Love it. This has been bothering me for a while.
I actually did this awhile back but couldn't figure out how to do a single-click instead of long click on the ellipses
somehow this works though. amazing.
this is so good. thank you
Had to revert this since it's causing that navigation issue
@ericholguin @jb55
I don't believe the changes in this PR are directly causing the navigation bug. For some reason, this bug shows up simply by removing the existing TextEvent
context menu in Master.
Remove line 69
in TextEvent (Master) to reproduce the bug:
.event_context_menu(event, keypair: damus.keypair, target_pubkey: pubkey, bookmarks: damus.bookmarks)
The cause of the bug seems to be the ImageCarousel
context menu. I am unable to reproduce the bug after removing line 213-217
in ImageCarousel (Master)
.contextMenu {
Button(NSLocalizedString("Copy Image", comment: "Context menu option to copy an image to clipboard.")) {
UIPasteboard.general.string = url.absoluteString
}
}
Is the outer context menu masking the inner context menu bug? I'm not sure why this happening or how to fix it other than removing the inner context menu. This might be a SwiftUI bug. Maybe we should remove the inner context menu until we can resolve the issue? The only menu option for the ImageCarousel
is copying the image url which is also available in the image viewer. Let me know what you all think.
thank you!!
thanks! merged in b6a7f52596aff4208e526a9bc3c3a65b591f01ad