damus icon indicating copy to clipboard operation
damus copied to clipboard

recognize relay links, and preview relays

Open alltheseas opened this issue 1 month ago • 2 comments
trafficstars

Summary

recognizes relay links, makes relay links tappable, and adds relay preview

image image

Checklist

  • [ ] I have read (or I am familiar with) the Contribution Guidelines
  • [x] I have tested the changes in this PR
  • [ ] I have profiled the changes to ensure there are no performance regressions, or I do not need to profile the changes.
    • Utilize Xcode profiler to measure performance impact of code changes. See https://developer.apple.com/videos/play/wwdc2025/306
    • If not needed, provide reason:
  • [x] I have opened or referred to an existing github issue related to this change. https://github.com/damus-io/damus/issues/2109
  • [ ] My PR is either small, or I have split it into smaller logical commits that are easier to review
  • [ ] I have added the signoff line to all my commits. See Signing off your work
  • [ ] I have added appropriate changelog entries for the changes in this PR. See Adding changelog entries
    • [ ] I do not need to add a changelog entry. Reason: [Please provide a reason]
  • [ ] I have added appropriate Closes: or Fixes: tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches

Test report

Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.

Device: xcode simulator iPhone 17 pro

iOS: iOS 26

Damus: 1.15 (1) f2870b9a

Setup: _ Steps: find a note with a wss://relay... address, tap on relay link, observe preview relay view

Results:

  • [ ] PASS
  • [ ] Partial PASS
    • Details: [Please provide details of the partial pass]

Other notes

@ericholguin to take a pass at improving

alltheseas avatar Oct 15 '25 20:10 alltheseas

@ericholguin may tinker with this relay preview view. Feedback (unincorporated thus far):

...relay link should look like a website preview

alltheseas avatar Oct 15 '25 21:10 alltheseas

Screenshot 2025-10-15 at 5 07 39 PM

is this what you mean @ericholguin ?

alltheseas avatar Oct 15 '25 22:10 alltheseas