damus
damus copied to clipboard
adds full longform highlight support. signed by npub1zafcms4xya5ap9zr…
…7xxr0jlrtrattwlesytn2s42030lzu0dwlzqpd26k5
Summary
Added full longform highlight support by allowing creation of longform highlights, and rendering source of longform highlights, and allowing navigation to highlight source by tapping on the highlight or source link.
Checklist
- [ ] I have read (or I am familiar with) the Contribution Guidelines
- [x] I have tested the changes in this PR
- [x] I have opened or referred to an existing github issue related to this change. Closes https://github.com/damus-io/damus/issues/3255.
- [x] My PR is either small, or I have split it into smaller logical commits that are easier to review
- [x] I have added the signoff line to all my commits. See Signing off your work
- [ ] I have added appropriate changelog entries for the changes in this PR. See Adding changelog entries
- [ ] I do not need to add a changelog entry. Reason: [Please provide a reason]
- [ ] I have added appropriate
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches
Test report
Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.
Device: xcode simulator iPhone 17 Pro
iOS: iOS 26
Damus: 1.15 (1) f2870b9a
Setup: _ xcode simulator_
Steps: [Please provide a list of steps you took to test the changes in this PR]
Results:
- [X] PASS
- [ ] Partial PASS
- Details: [Please provide details of the partial pass]
Other notes
[Please provide any other information that you think is relevant to this PR.]
create longform highlight in iOS Damus screenshot
view longform highlight in iOS Damus screenshot
verify in third party nostr app longform highlight
this PR also adds claude.md file that should assist with agent coding for future PRs
received feedback that there are hundreds of unnecessary files, unnecessarily large PR size from iOS devs. investigating.
this PR https://github.com/damus-io/damus/pull/3276/ should remove all the unnecessary artifacts. I confirmed that https://github.com/damus-io/damus/pull/3276/ allows me to successfully create and read longform highlights on my physical device.