damus icon indicating copy to clipboard operation
damus copied to clipboard

Bug: Zaps not showing

Open rolznz opened this issue 1 year ago • 3 comments

What happens When I receive zaps to my node, they do not show in the Damus UI.

What I expect to happen I expect zaps to show.

Link to noteID, npub note1d2k8z60866a07pmxsy5rcp47jmdyskjz0n3d3tjg6dsj8l0jpd6sx2xwgt

Screenshots/video recording Damus: image

Primal Web: image

** Versions ** Damus version: 1.9 (14) Operating system version: iOS 17.5.1 Device iPhone 11

Steps To Reproduce Steps to reproduce the behavior:

  1. Open this link in Damus: https://damus.io/nevent1qqsx4tr3d8nadwhlqangz2puq6lfdkjgtfp8eckc4eydxcfrlheqkagprfmhxue69uhhyetvv9ujumn0wd68yurvv438xtnrdakszrthwden5te0dehhxtnvdakqzynhwden5te0wp6hyurvv4cxzeewv4esz9rhwden5te0wfjkccte9ehx7um5wghxyec598npw
  2. View zaps

Additional context This seems to do with the description hash validation, which should have been fixed by https://github.com/damus-io/damus/commit/43630cbfa650f731c4843dc4acb5dcd9f792d8f0 but it does not seem to.

rolznz avatar Jul 29 '24 07:07 rolznz

@rolznz was this the first time you saw this note? By chance did you previously zaps that disappeared?

alltheseas avatar Jul 29 '24 10:07 alltheseas

@alltheseas I don't understand your question. I posted this note and I tried viewing it multiple times, the zaps never show

rolznz avatar Jul 29 '24 12:07 rolznz

@alltheseas I don't understand your question. I posted this note and I tried viewing it multiple times, the zaps never show

You answered my question. Sometimes zap appear, and later disappear on damus.

alltheseas avatar Aug 06 '24 16:08 alltheseas

it either can't find the note from your relay list or the zaps are invalid

jb55 avatar Feb 26 '25 05:02 jb55

This was fixed a long time ago - it was an issue with the description hash validation, sorry for not updating the issue

rolznz avatar Feb 26 '25 05:02 rolznz