damus icon indicating copy to clipboard operation
damus copied to clipboard

Bug: non-aligned return button in profile view iOS 18 beta

Open tkhumush opened this issue 1 year ago • 6 comments
trafficstars

What happens When I view a profile by clicking a users profile picture or name, the Back button and more options buttons are centered at the top, and only snap into place after sliding to go back.

What I expect to happen The Back and options buttons should be located at the top ends of the screen left and right.

Screenshots/video recording https://github.com/user-attachments/assets/955cc9d9-819a-4377-a71e-5307a430b78a

** Versions ** Damus version: 1.9 (14) Operating system version: iOS18 Beta 4 Device: iPhone Pro 14 Max

Steps To Reproduce Steps to reproduce the behavior:

  1. Open profile
  2. Slide back, but don't go to previous screen.

Additional context This only started on iOS18.

tkhumush avatar Jul 24 '24 16:07 tkhumush

Thanks @tkhumush for the concise report.

Lets wait for apple's final September iOS 18 release to see if this remains open

alltheseas avatar Jul 24 '24 19:07 alltheseas

I cannot recreate on iOS 17. Seems like iOS 18 as stated by @tkhumush

alltheseas avatar Jul 24 '24 19:07 alltheseas

I saw this was fixed by @tyiu

tkhumush avatar Jul 30 '24 18:07 tkhumush

Yes. PR here: https://github.com/damus-io/damus/pull/2355

alltheseas avatar Jul 30 '24 18:07 alltheseas

Adding to 1.11 pending @danieldaquino thumbs up 🙏

alltheseas avatar Jul 30 '24 19:07 alltheseas

@alltheseas thanks for adding it to 1.11, I agree with that 👍

danieldaquino avatar Jul 30 '24 20:07 danieldaquino

Closing since this is fixed

jb55 avatar Sep 07 '24 17:09 jb55