damus icon indicating copy to clipboard operation
damus copied to clipboard

Profile names and PFP dont render

Open alltheseas opened this issue 1 year ago • 11 comments

What happens When I am scrolling my timeline, sometimes names dont render.

image

image

image

note132sf7v7vpqcrxghtxza25ln38pc7dxxvhkc9w3y63462nhpzt6xs5p7xlp

nprofile1qqs2fj6373scelx3dvknzuwyvctehmvwr97y8wze3q3mqn0zvm80zyqpzfmhxue69uhk7enxvd5xz6tw9ec82csprfmhxue69uhhyetvv9ujummjv9hxwetsd9kxctnyv4mqz9nhwden5te0wfjkccte9ehx7um5wghxyctwvsqs6amnwvaz7tmwdaejumr0dsnukde2

npub15n94rarp3n7dz6edx9cugeshn0kcuxtugwu9nzprkpx7yekw7ygqplqru4

Context

Even with purple pages (profile indexer relay)

alltheseas avatar May 18 '24 14:05 alltheseas

Came here to post this. Thanks @alltheseas for documenting.

Commenting because I don't know how to bring attention to it.

tkhumush avatar Jul 12 '24 16:07 tkhumush

@tkhumush keep posting screenshots, describing what happens, and sharing noteIDs

alltheseas avatar Jul 12 '24 18:07 alltheseas

I continue seeing this. As do Vanessa, @danieldaquino

alltheseas avatar Jul 17 '24 18:07 alltheseas

@jb55 name does not render. We share the same relays, and follow each other. Major regression happened.

image

alltheseas avatar Jul 25 '24 12:07 alltheseas

image

Damus does not render my own profile name. This is bad.

alltheseas avatar Jul 27 '24 11:07 alltheseas

investigate @danieldaquino -git log to check what changed / potentially triggered this issue

alltheseas avatar Aug 26 '24 16:08 alltheseas

Duplicate or related https://github.com/damus-io/damus/issues/1584

alltheseas avatar Sep 03 '24 05:09 alltheseas

Spent some time today trying to debug this, and I could reproduce this a few times, but after about 30 min to 1hr of debugging I stopped being able to reproduce this issue at all — I can scroll very fast, jump around my feed very fast and not get a single profile render issue, even after restarting the app 🤔

Device: iPhone 13 Mini iOS: 17.6.1 Damus: da7af491d0748ce4d4c03d2db66335888dd5dd06

I have previously tried to examine git logs, and the only log that seems somewhat related is:

commit e3642b92d137f2e175e4c9011c077ee2a7d934f9
Author: William Casarin <[email protected]>
Date:   Fri Jan 26 14:03:49 2024 -0800

    txn: fix subtle transaction inheritence bugs

    This fixes subtle bugs with transaction inheritence. Since we were not
    passing the inherited state to moved value, we were sometimes committing
    transactions more than once.

    Changelog-Fixed: Fix many nostrdb transaction related crashes

But given the date, I find it unlikely to be the cause.

I will try to reproduce it again tomorrow

danieldaquino avatar Sep 06 '24 01:09 danieldaquino

See https://github.com/damus-io/damus/issues/1982

alltheseas avatar Sep 06 '24 22:09 alltheseas

See #1982

This is great info! Thanks @alltheseas for linking this, this gives me some ideas on how to repro and fix this.

danieldaquino avatar Sep 07 '24 00:09 danieldaquino

Spotted an instance

image

image

alltheseas avatar Sep 15 '24 16:09 alltheseas

image

note1tulgew4l56z6hh9mc5x9lttngrx2muf3ach4r5f7fzqdck5tzjtqxlunu3

One more instance @danieldaquino

npub1jlrs53pkdfjnts29kveljul2sm0actt6n8dxrrzqcersttvcuv3qdjynqn

alltheseas avatar Nov 19 '24 17:11 alltheseas

Now happens to my own name

image

alltheseas avatar Dec 07 '24 22:12 alltheseas

can’t see your pfp on Damus anymore. Wonder why.

https://njump.me/note1rzfzcuc5ra5rpavc3synqvrakgmvz6vxwlp353t75k3xdgpzw5zsnmgwn6

alltheseas avatar Dec 19 '24 15:12 alltheseas

https://damus.io/nevent1qqs8qfuhdl8apg8q2pvv7wc52edjcepr46lwqpjhjg3tpw8a2nelu5qd9pgtq

I’m not sure why, but for some reason I can’t see your profile pic or name when I’m using Damus. When is the last time you refreshed your bio? I’m trying to figure out why you’re one of the only users who always comes up as just an anonymous npub for me.

image

alltheseas avatar Jun 09 '25 11:06 alltheseas