note links (bug/enhancement)

[olheadinternet]

There are some bugs mentioned below, but my general proposal is: notes with more than 1 linked note should not have a preview, rather tapping on the note should lead to a thread with just the linked notes, and a button to "expand" from there.

---

3rd note missing in damus

Test 1: note1ad643jqnm4wygfn0afdtgea9a56dqc78e7pjgllc2x5eauulunysjuuzjl

and replicated with text between notes: (see test 1.2 in next section)

however when test 1 is rendered as a quote note… it does show all 3 notes as seen in test 2, but that goes away if you enter thread view

test 2: note1yw7tdjrmvt9gnvvjsqtr59tx46stantzwfytd8gmz45aygphzj4qr99n0u

---

I also tried to surround the links with text...

test 1.2: note187tpva2pdey6kgj4mcd52eu3z9rrl9vu5kx98x036qcd9e3x5vrq7ph9mk

not only is the 3rd link missing but the text above it "test c:" is also missing.

---

in my mind what should happen when I click the following note is i am first presented with the notes that are linked, they are older because they have to exist first, and should render above this note:

note10ewyvqpwscqe3c6ctarjeyj8enxrtv7wmpzl58dg3rf2q3qgyuuqm8apav

that note was sent prior to 0.1.8(5) with the thread update… that also has 3 note links. In this instance none of the note links appear, text of note isn’t shown in full, the first link does render as a quote.

I’m seeing ~boosts~ and mentions of this note below, which I’m ok with, but sequentially I want to see the notes mentioned in the note first, then expand the conversation if I want to see conversation around that note.

---

vishalxl replied to one of my tests with these screen shots of what they look like in console & astral https://github.com/vishalxl/Nostr-Clients-Features-List/issues/3#issuecomment-1366530567

There isn't the space to do that in damus, notes with more than 1 linked note should not have a preview, rather tapping on the note should lead to a thread with just the linked notes, and a button to "expand" from there.

---

[olheadinternet]

here is a test with an invoice followed by a note link, note link disappears

note18ywu835z6ny6hhhsytpungxt7m43zp0ae24j64s3zjxu44cyy34qmxzjnr

Update with wider invoice design... still can't see the note link

note13eue56zmkd8wnxctflhhjn8d260hxzws90c8zrmztq22tu3g5rks6gcu8n

---

here is a test with a note link followed by a invoice, works fine. the text doesn't render fully in portrait... the text does fully render in landscape.

note1630vnckghc8mad4gjdm9h3shmt7sqk2zuhtlks5msapznvxsn9gs5hykzm

[olheadinternet]

seems like fixing boosts showing up in replies also fixed this.

~i sent a note link in a dm. the preview box takes up the whole screen of my dm list.~

~also the dm shows up in replies under the note that i linked too for me, and is rendered like it's just a note i sent out.~

[olheadinternet]

as of 1.0.0 (3) note quote preview has been removed, I assume temporarily... but my proposal still stands when their gui is updated.