angular-auth-oidc-client icon indicating copy to clipboard operation
angular-auth-oidc-client copied to clipboard
verified publisher icon damienbod

[Bug]: StsConfigHttpLoader invokes constant message events

Open niiloliimatainen opened this issue 4 years ago • 3 comments

What Version of the library are you using? 13.1.0

Describe the bug Runtime configuration with StsConfigHttpLoader invokes constant browser message events. Every event will invoke Angular's change detection cycle, which will lead to performance problems.

To Reproduce Steps to reproduce the behavior:

  1. Follow the documentation's 'Load config from HTTP (async)' sample code: documentation
  2. Run the app
  3. Use Angular dev tools to track change detection cycles
  4. Check the sources for change detection cycles

Expected behavior StsConfigHttpLoader won't invoke any unnecessary change detection cycles.

Desktop (please complete the following information):

  • OS: Windows 10 enterprise
  • Browser: Chrome
  • Version: 98.0.4758.102 (Official Build) (64-bit)

niiloliimatainen avatar Mar 07 '22 13:03 niiloliimatainen

Hi @niiloliimatainen The docs have been updated for V14, but we have not released yet.

damienbod avatar Mar 15 '22 19:03 damienbod

Hi @damienbod , is the bug going to be fixed in V14, and can you give any info on the V14 release date?

niiloliimatainen avatar Mar 21 '22 09:03 niiloliimatainen

I am not sure if the CD runs if you did not register on the events. Or at least one of the events. We have to investigate. Don't know if it will make it to V14 if this turns out a bug.

FabianGosebrink avatar Mar 22 '22 08:03 FabianGosebrink

Is this still a thing?

FabianGosebrink avatar Aug 07 '22 11:08 FabianGosebrink