cucumber-reporting icon indicating copy to clipboard operation
cucumber-reporting copied to clipboard

Feature number is added to feature report file name even if only 1 json file is parsed

Open pawelusfr opened this issue 4 years ago • 3 comments

Steps to reproduce Parse 1 json file containing multiple features

Expected result HTML file names should have format report-feature_<hash>.html

Actual result HTML file names have format report-feature_<featureNumber><hash>.html This causes problems when trying to link to cucumber report from external tools as featureNumber is reliant on arbitrary order of features in the json file which external tools don't know and can't guess.

Comments This happens because calculateReportFileName in Feature.java expects first parameter to be json file number but it is actually called with feature number from ReportResult.java

pawelusfr avatar Dec 21 '20 13:12 pawelusfr

@damianszczepanik do you think it's something that can be changed?

pawelusfr avatar Jun 28 '21 08:06 pawelusfr

Hash stays unchanged across report executions

damianszczepanik avatar Jul 10 '21 15:07 damianszczepanik

I've checked the code and from report generation perspective that would be hard at the current implementation as later feature do not have direct reference to the file numbers

damianszczepanik avatar Jul 10 '21 15:07 damianszczepanik