golog icon indicating copy to clipboard operation
golog copied to clipboard

feat: support any type in encoder

Open damianopetrungaro opened this issue 2 years ago • 1 comments

I am not convinced this project should support any type.

Performances for this use case may be a good selling point since the implementation designed is more efficient than other loggers around.

New benchmarks supporting any:

goos: darwin
goarch: amd64
pkg: github.com/damianopetrungaro/golog/benchmarks/logger
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkLogger/golog-12                   72630             16335 ns/op           17348 B/op        128 allocs/op
BenchmarkLogger/zap-12                     58617             20173 ns/op           28346 B/op        125 allocs/op
BenchmarkLogger/logrus-12                  66474             18344 ns/op           13882 B/op        172 allocs/op
BenchmarkLogger/golog.Check-12          53974438                22.63 ns/op           64 B/op          1 allocs/op
BenchmarkLogger/zap.Check-12            1000000000               0.8838 ns/op          0 B/op          0 allocs/op
PASS
ok      github.com/damianopetrungaro/golog/benchmarks/logger    6.494s

damianopetrungaro avatar Apr 29 '22 23:04 damianopetrungaro

Codecov Report

Merging #28 (a6587fc) into main (18c8ec6) will increase coverage by 0.17%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   89.82%   90.00%   +0.17%     
==========================================
  Files          15       15              
  Lines         796      810      +14     
==========================================
+ Hits          715      729      +14     
  Misses         70       70              
  Partials       11       11              
Impacted Files Coverage Δ
encoder.go 100.00% <100.00%> (ø)
field.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e8c6fa...a6587fc. Read the comment docs.

codecov[bot] avatar May 03 '22 22:05 codecov[bot]