Mike Dame

re: out of tree plugins it would be great if we could pick up https://github.com/kubernetes-sigs/descheduler/pull/1087 and https://github.com/kubernetes-sigs/descheduler/pull/1092, unless we want to wait and solve https://github.com/kubernetes-sigs/descheduler/issues/1089 first

The idea is to instrument user apps. Right now, the general approach with auto-instrumentation is to run your app+instrumentation as a sidecar. If you're running the collector as another sidecar,...

Yeah I think a refined, exposed Probe interface inherently provides the mechanism for custom probes. But calling out that that is intentional is good to do

@RonFed this is a great overview, thanks for writing that up * +1 to the idea of splitting `Load` and `Attach`. I think having atomic operations is much clearer and...

From the sig meeting, my thinking of basing Probe config off the [k8s scheduler framework](https://kubernetes.io/docs/concepts/scheduling-eviction/scheduling-framework/) (specifically the [Plugin API](https://kubernetes.io/docs/concepts/scheduling-eviction/scheduling-framework/#plugin-api)) If we have 2 types of probe `ProbeA` and `ProbeB` we...

@RonFed I'll try to put together a more concrete prototype, I was looking into it and got kind of sidetracked just thinking about the overall structure. On that note, I...

@RonFed sounds good, so to show what I'm saying I did an example with db/http here: https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1123 Could you show what you mean for a `SupportedConfig()` method like you proposed?...

as part of this (and shifting Probes to `NewInstrumentation()`) we would also define a method signature for a probe's `New()` func that enforces passing `probe.Config` as an argument.

@RonFed yeah I just used `Package()` as an example of something that all Probes might need to expose to the Instrumentation machinery (in this case I used it just for...

@MrAlias and I were talking about this last week, and I think the points we came up with for the design were (let me know if I missed anything): *...