Mike Dame
Mike Dame
In addition to this as mentioned in https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/724#issuecomment-1993735802 the tutorial app should be updated because the current one will not work if we don't support
Would add that a clear definition of what falls under the experimental flag to help us and users. I think that includes: * Semconv stability * Stability of the library...
@MrAlias totally agree, I was just proposing those 3 requirements. I think ultimately if it's not user facing, then it doesn't have to be a requirement for our stability level....
That's a good point @edeNFed @pellared, I didn't think to consider how other auto-instrumentation agents handle this. I think not deviating from the precedent set by other languages (along with...
Hi @austinlparker! The libbpf files were included for easier linkage during compilation of our C files. At that time, we found that it is dual-licensed under BSD (https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/4#issuecomment-1296849147) which is...
Latest semconv: https://github.com/open-telemetry/semantic-conventions/blob/21b8f4620d2029fe8abb98a4a06655da3232d11d/docs/database/sql.md Required attributes: * `db.collection.name` (“if readily available. The collection name MAY be parsed from the query text, in which case it SHOULD be the first collection name...
The error `map .rodata: map create: read- and write-only maps not supported (requires >= v5.2)` is referring to kernel version 5.2. [Our docs](https://github.com/open-telemetry/opentelemetry-go-instrumentation?tab=readme-ov-file#prerequisites) only list version 4.19 as the minimum...
Maybe relevant -- ? https://github.com/open-telemetry/opentelemetry-go-instrumentation/issues/220
Latest RPC conventions: https://github.com/open-telemetry/semantic-conventions/blob/02ecf0c71e9fa74d09d81c48e04a132db2b7060b/docs/rpc/rpc-spans.md and specifically the gRPC conventions (which extend and override RPC): https://github.com/open-telemetry/semantic-conventions/blob/02ecf0c71e9fa74d09d81c48e04a132db2b7060b/docs/rpc/grpc.md > ## Common remote procedure call conventions > For outgoing requests, the `SpanKind` MUST be...
For `rcp.grpc.status_code`, I think if we update our return probe instrumentation for `Invoke` to read the returned error object, that should get us what we need. gRPC seems to return...