Mike Dame
Mike Dame
Overall, I'm personally against this because it doesn't have a clear use case and is designed to detriment an existing plugin. I think doing this will encourage users to use...
> yes, making use of `included` invalid/forbidden in the preEvictionFilter EP to clarify, we are only talking about NodeUtilization strategies right? Others can still use include If making include available...
> Any plugin using preEvictionFilter will be affected That's not good, I didn't realize the scope of this. Any plugin should have the *option* of using either/or Include/Exclude, but they...
> As providers of the upstream plugins with default setting and validation for all "approved" plugins we can make sure the namespace inclusion/exclusion is limited for specific strategies. However, we...
Maybe it would be good to see a poc change with that kind of enforcement applied? I'm getting a little confused so seeing the alternative implementation could help inform a...
@ingvagabund ah, I see. That seems like a reasonable approach for plugin developers to take imo Instead of enforcing it against a specific evictor, could it enforce that the evictor's...
@harshanarayana I checked out your branch locally and it fails when I run it with the same output as the CI. Could you try running `make clean` first, or perhaps...
@harshanarayana I think it has something to do with https://github.com/kubernetes-sigs/descheduler/pull/982, but I can't quite figure it out. Posted a more detailed explanation there
@harshanarayana could you rebase and try running the scripts again to see if there's any changes now? /retest
@harshanarayana is there a reason for the [deepcopy gen tag](https://github.com/kubernetes-sigs/descheduler/blob/d33137b47340deeda22191f17456b96ecdd5b58f/pkg/apis/componentconfig/v1alpha1/types.go#L68) on `TracingConfiguration`? (also in the unversioned type) that might be the problem, can you try without it? (btw, please be...