Mike Dame

Results 391 comments of Mike Dame

> Yes, I browsed the release page for details. IMO, it's less convenient to search across multiple release. Considering we already post the changes for each release, I think it‘s...

It seems reasonable to me that there are other strategies that could benefit. from the `states` parameter. This might take a back seat while we focus on the framework migration,...

I also noticed that on PRs from first-time contributors, now I have to click a button to manually approve the Helm test action (separate from `/ok-to-test`). We can probably change...

Hey @Dentrax @harshanarayana, thanks for proposing this! I'm actually on the OpenTelemetry team at google now, so I'm happy to help with any reviews or questions. The SDK in the...

the API server's otel dependencies were just updated to the latest versions in https://github.com/kubernetes/kubernetes/pull/112545 🎉 so we should be unblocked now right?

> Also we need to pass tracing client into frameworks to trace each one individually. There's the [global package](https://pkg.go.dev/go.opentelemetry.io/otel/global) that might work for us, it lets you register Providers for...

> What modes of exporter do we support ? We should only need to focus on OTLP support. Jaeger already supports OTLP and Otel has the [collector](https://opentelemetry.io/docs/collector/), which is the...

@harshanarayana it's probably because the PR adds it to [`pkg/apis/componentconfig/types.go`](https://github.com/kubernetes-sigs/descheduler/pull/958/files#diff-8cb3a832fd89345b8caf52788b477463aaf7cd78c7a947d55eef89fdc1d5e12f) but not [`pkg/apis/componentconfig/v1alpha1/types.go`](https://github.com/kubernetes-sigs/descheduler/blob/master/pkg/apis/componentconfig/v1alpha1/types.go). It may or may not ultimately end up in the componentconfig as we work out the v1alpha2...

> In the issue we said we should have every strategy in v1alpha1 converted into a separate v1alpha2 profile, but here I prefered converting into a single profile I agree...

> what was the reasoning behind moving plugin args into their own package? I noticed that for KS they still keep it under the config package this is a more...