Danny McCormick

Results 90 comments of Danny McCormick

(resolved some conflicts and cleaned up CHANGES.md while at it)

Oh whoops, missed https://github.com/apache/beam/pull/30976/commits/91d4dc1af683c87808048bc03ed180522b12c13d - thanks for catching

This was working last month - https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python_Arm.yml?query=is%3Asuccess+branch%3Amaster+event%3Aschedule

Looks like it went flaky then permared around then

@volatilemolotov could you put up a PR to make that change? Definitely seems like it is getting further. @svetakvsundhar do you know what scope is missing? Given the normal postcommit...

Thanks - merged, lets see what the result on master is

Great, thanks @volatilemolotov Looks like we're still flaky - https://github.com/apache/beam/actions/runs/8843342204/job/24283441647 - but that's an improvement and it looks like a test flake instead of infra

I think that's wrong - https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python_Arm.yml?query=branch%3Amaster+event%3Aschedule

Fixed by https://github.com/apache/beam/pull/32530

> How exactly does the codecov bot invoke tests? I suspect that the new module should have ~100% coverage but the new test probably is getting missed somehow by codecov...