Christopher Pappas

Results 72 comments of Christopher Pappas

In this case, i would highly recommend using styled-system's approach to media queries, where you can pass in arrays. https://styled-system.com/responsive-styles. Many different libraries now support this approach, including Artsy's [design...

Ah, sorry for closing so soon! Can reopen. But just a heads up we'll accept PRs, but don't have the resources to work on feature recommendations at this time.

@gurkerl83 - which comments are you referring to? (I'm not seeing anything in this PR.) Hoping to wrap this up today; we're in the middle of a product launch right...

If you can hit the 'finish review' button then i'll see your comments; i can't see them until they've been posted.

> but I see a few of mine in pending state If i'm understanding correctly, it seems like you've submitted PR comments as part of a PR review, but haven't...

PR is green and all of our existing tests pass, so going to ship this out @gurkerl83. For any other follow-up issues please comment on the PR here or in...

Going to close this and update via `yarn`

One thing that this would impact is SSR rendering, as outlined in the ["Why not conditionally render"](https://github.com/artsy/fresnel#why-not-conditionally-render) section of the docs. That said, I think this hook could have some...

So like, the question is how to programmatically represent the underlying architecture of this node structure 🤔: ``` ... ``` It seems like all the bits are there to do...

cc @dzucconi - have you run into a solution to this before?