Verify upgrade_app_rules functionality
GitHub Actions is reporting that no changes are being detected the upgrade_app_rules flow. Based on activity in the upstream app rules repo, this seems unlikely.
For example, see https://github.com/dalyIsaac/Whim/actions/runs/13420543713/job/37491857685
It's because an upstream upgrade in the scheme, which changed the format from yaml to json. New rules aren't backported to the yaml.
I have been meaning to upgrade the python script but was wondering whether it might be worth revisiting which information to leverage in whim.
For reference, here's the documentation of the new "v2" scheme: https://github.com/LGUG2Z/komorebi-application-specific-configuration/#v2
As a baseline, we could just upgrade the script and do more or less what we have been doing now. With the new scheme, that would probably mean to add filter rules for both ignore and floating. Relative to that, would you want to do anything else? E.g.,
- Treat
ignoredifferently thanfloating? - Use some of the other flags for dealing will ill-behaved applications? E.g.,
object_name_changeandslow_applicationlook like they could also be relevant for Whim. - Now that Whim supports json based config, do you still want to convert all the rules to
cs, or would a json format be more convenient?
Hmm, that's interesting. I like making a distinction between ignoring and floating - conflating the two always seemed a bit peculiar. All the changes in the schema all seem good at a glance.
I think the ideal thing would be to consume the config as is. I imagine this would be done probably as a new plugin, and while it wouldn't be outrageous it'd be a non-trivial piece of work.