tarkit icon indicating copy to clipboard operation
tarkit copied to clipboard

Published 20 hours ago • verified publisher icon daltoniam

Buffer Overflow When Padding is Written at EOF

Open heshuimu opened this issue 6 years ago • 1 comments

https://github.com/daltoniam/tarkit/blob/62d1c23eaf4cc222dffc5ff333ee83d68b590111/DCTar.m#L525-L529

Should have been:

[outputFileHandle writeData:[NSData dataWithBytes:buffer length:padding]];

heshuimu avatar Dec 25 '18 16:12 heshuimu

Yeah. That looks like an error. Great catch! Can you create a PR to fix this @heshuimu ?

drallgood avatar Dec 31 '18 04:12 drallgood