Starscream icon indicating copy to clipboard operation
Starscream copied to clipboard

Fixed zlib dependency for Linux

Open ypopovych opened this issue 4 years ago • 7 comments

Used the same approach as in SwiftNIO (C target with a linked native library). If CommonCrypto dependency will be resolved can be compiled on Linux.

ypopovych avatar Oct 15 '20 17:10 ypopovych

Hi folks, seeing if there was any update here?

dmiluski avatar Jul 22 '21 18:07 dmiluski

Sorry to ask but how do you edit the SwiftPM?

SammyAlvarado avatar Sep 22 '21 12:09 SammyAlvarado

@daltoniam hey is there anything blocking this? Can I/we help in getting this merged and released at all?

danpalmer avatar Oct 04 '21 15:10 danpalmer

Is this solution going to be merged ?

raisameneses avatar Dec 02 '21 15:12 raisameneses

Sorry to ask but how do you edit the SwiftPM?

Hey @SammyAlvarado. In order to edit SPM, you need to take it to the locally.

You can read this article: https://developer.apple.com/documentation/swift_packages/editing_a_package_dependency_as_a_local_package.

canbalkaya avatar Mar 24 '22 08:03 canbalkaya

please merge. the branch Screen Shot 2022-09-04 at 10 18 54 am

the patched version seems broken Screen Shot 2022-09-04 at 10 19 34 am

gh repo clone daltoniam/Starscream Cloning into 'Starscream'... remote: Enumerating objects: 3251, done. remote: Counting objects: 100% (61/61), done. remote: Compressing objects: 100% (45/45), done. remote: Total 3251 (delta 28), reused 29 (delta 14), pack-reused 3190 Receiving objects: 100% (3251/3251), 2.68 MiB | 593.00 KiB/s, done. Resolving deltas: 100% (1752/1752), done. (base) ➜ test cd Starscream (base) ➜ Starscream git:(master) gh pr checkout 844 remote: Enumerating objects: 13, done. remote: Counting objects: 100% (7/7), done. remote: Total 13 (delta 7), reused 7 (delta 7), pack-reused 6 Unpacking objects: 100% (13/13), 1.21 KiB | 103.00 KiB/s, done. From https://github.com/daltoniam/Starscream

  • [new ref] refs/pull/844/head -> tesseract-one/master Switched to branch 'tesseract-one/master'

UPDATE you can merge pr into own fork - or use mine - maybe use exact.

dependencies: [ .package(url: "https://github.com/wweevv-johndpope/Starscream.git", from: "4.0.4-fix") ],

johndpope avatar Sep 04 '22 00:09 johndpope

Im using this library with swift Vapor framework and im getting an error about zlip dependency while deploying my application on Heroku. I need your helps guys. @daltoniam @johndpope

Ekran Resmi 2023-11-17 14 17 20

cemaltuysuz avatar Nov 17 '23 11:11 cemaltuysuz