puppetexplorer icon indicating copy to clipboard operation
puppetexplorer copied to clipboard

Latest puppetexplorer broke compatibility with PuppetDB < 3.0.0

Open lesinigo opened this issue 9 years ago • 7 comments

After upgrading a working system to the latest puppetexplorer it refused to work anymore.

At first there was a trivial change to our proxy for PuppetDB (/api/v4 became /api/pdb/query/v4). We quickly fixed it, but please do note that it doesn't appear to be fixed in spotify-puppetexplorer module.

Then we're stuck with "Unsupported query parameter 'order_by'". It seems that PuppetDB 3.0 changed it from the older "order-by" to the newer "order_by": http://docs.puppetlabs.com/puppetdb/3.0/api/query/v4/upgrading-from-v3.html

It would be cool if Puppetexplorer could retain compatibility with PuppetDB < 3.0 (maybe via a configuration parameter?), but if it couldn't it should be noted in the Dependencies section of README.md.

lesinigo avatar Aug 24 '15 15:08 lesinigo

A lot more was changed to support PuppetDB 3.0, especially in commit https://github.com/spotify/puppetexplorer/commit/2e962b7afdb794c2b756a365ef7dcf37c134618f. Too bad there's no compatibility with 3.0 any more. We've downgraded to 1.5.0 now.

ju5t avatar Aug 24 '15 20:08 ju5t

but if it couldn't it should be noted in the Dependencies section of README.md.

It was mentioned in the release notes of puppetexplorer 2.0.0 https://github.com/spotify/puppetexplorer/releases/tag/2.0.0

sheijmans avatar Aug 26 '15 13:08 sheijmans

Then I should mention that release notes and README.md are out of sync, since the latter says "the current version only works with PuppetDB 2.1" :-)

lesinigo avatar Aug 26 '15 15:08 lesinigo

That was a mistake, I'll fix the readme tomorrow when I'm back home again. I'll also try to fix the version check so it also queries the old version api and displays the error message about too old puppetdb version.

dalen avatar Aug 26 '15 16:08 dalen

it would also be nice if one could still access the pre 2.x rpms on http://yum.puppetexplorer.io/

TheMeier avatar Aug 26 '15 16:08 TheMeier

I'll take a look why they aren't available there. They are however downloadable from the github releases tab on each release.

dalen avatar Aug 26 '15 16:08 dalen

@TheMeier: I just downloaded it from http://yum.puppetexplorer.io/puppetexplorer-1.5.0-1.noarch.rpm, removed the old puppetexplorer package and installed this one. I tried yum downgrade first, but when that didn't work I couldn't be bothered too much to find out why it didn't.

ju5t avatar Aug 26 '15 19:08 ju5t