angular-bootstrap-datetimepicker icon indicating copy to clipboard operation
angular-bootstrap-datetimepicker copied to clipboard

Upgrade Angular 13

Open dalelotts opened this issue 3 years ago • 4 comments

Upgrade Angular 13

What is the use-case or motivation for this proposal?

It's been to long since I have updated this project, so I will upgrade to Angular 13+ and add some more features.

Is there anything else I should know?

Let me know in the comments below if you have a specific request.

dalelotts avatar Oct 31 '21 15:10 dalelotts

Angular 13 is out now :) Also #449 would be great

mariojsnunes avatar Jan 20 '22 17:01 mariojsnunes

Thanks for the update - I will upgrade to 13, waiting on a bug in typescript which is already fixed but not used by Angular yet. 🤷‍♂️ Part of that work will be enabling #449

dalelotts avatar Jan 20 '22 17:01 dalelotts

@dalelotts Is the update to Angular 13 still planned? :)

MarieOlligesgeers avatar Jul 19 '22 09:07 MarieOlligesgeers

@MarieOlligesgeers It is still planned, but I've have essentially no time for Open Source projects right now.

I have not verified the typescript bug is fixed either.

I'm happy to merge a PR if someone wants to contribute.

dalelotts avatar Jul 19 '22 19:07 dalelotts

Hey @dalelotts - I have just opened a PR with update to angular 13. Please see it here: https://github.com/dalelotts/angular-bootstrap-datetimepicker/pull/515 If you ok with the changes then please merge them and please publish the new version of the library with 13.0.0 version number. Please see the PR's description for details. Sorry for not getting rid of the moment.js but it would be too much fuzz to do these two things in parallel. I am suggesting someone should do this in a separate PR.

Thx in advance for your help!

tszewcow avatar Jan 19 '24 08:01 tszewcow

Done as part of #515

dalelotts avatar Feb 07 '24 15:02 dalelotts