curve25519-dalek icon indicating copy to clipboard operation
curve25519-dalek copied to clipboard

Increase MSRV to allow for Zeroize > 1.4

Open hariria opened this issue 2 years ago • 6 comments

Hi, is there any chance we can increase the minimum supported rust version and zeroize to > 1.4? It conflicts with a lot of other crates. Thanks!

Based on what i'm seeing here: https://github.com/Devolutions/picky-rs/issues/140#issuecomment-1093662134

hariria avatar Apr 13 '22 22:04 hariria

I, too, am curious about this.

samuelvanderwaal avatar Jul 20 '22 00:07 samuelvanderwaal

What is the problem? Why are setting <1.4 restriction on Zeroize?

rcolomina avatar Sep 05 '22 22:09 rcolomina

We are hitting this in the webrtc-dtls crate too. We have both elliptic-curve and curve25519-dalek in our tree. [email protected] requires zeroize > 1.5 and curve25519-dalek requires zeroize < 1.4

k0nserv avatar Sep 07 '22 18:09 k0nserv

Hitting a similar issue to @k0nserv at work with the aws-sdk crates which require zeroize ^1.4.

It's very common in the Cargo ecosystem for MSRV bumps to exist in minor versions. If users of the crate wish to remain on an outdated compiler, they are able to solve MSRV problems themselves by pinning deps (even deep ones) in their own application's manifest.

robjtede avatar Sep 15 '22 12:09 robjtede

Same problem here with aws-sdk crates and ethereum web3 crates

juliotpaez avatar Oct 10 '22 07:10 juliotpaez

Just linking to the issue that established this pinned version: https://github.com/dalek-cryptography/curve25519-dalek/issues/362

brson avatar Oct 15 '22 20:10 brson

This is now resolved in the release/4.0 branch. Next release (or prerelease) will have a laxer zeroize dependency.

rozbb avatar Oct 18 '22 18:10 rozbb

@rozbb When can we expect a release here? I think for many folks this problem remains unresolved until a release is made(pointing to GitHub will not work well in libraries I think).

Thanks for working on this by the way, really appreciate it

k0nserv avatar Oct 21 '22 10:10 k0nserv

@k0nserv see open items under https://github.com/dalek-cryptography/curve25519-dalek/labels/do-for-4.0

Also: #405

tarcieri avatar Oct 21 '22 12:10 tarcieri