filetree icon indicating copy to clipboard operation
filetree copied to clipboard

github:// urls - proper error message when a target repository or branch doesn't exist

Open peteruhnak opened this issue 8 years ago • 2 comments

Currently when I type in incorrect name of repo or a branch I just get a weird error saying that a zip wasn't found.

este

This is very cryptic when one encounters it for the first time. Why it shows error only when attempted to load the zip, and not during the download? Why did the download failed silently?

Ideally it could also tell what part is incorrect, e.g. good repo, but branch doesn't exist… but that would be probably unnecessarily complex.

peteruhnak avatar Mar 25 '16 09:03 peteruhnak

The code for handling github:// urls is in Metacello, not FileTree. Error detection and analysis is dependent on what the github API returns

ThierryGoubier avatar Mar 27 '16 14:03 ThierryGoubier

I'll also rename the issue, because it has nothing to do with GitFileTree :)

ThierryGoubier avatar Mar 27 '16 14:03 ThierryGoubier