lein-bikeshed
lein-bikeshed copied to clipboard
Subprocess fails on compojure
Leiningen 2.4, OS X Yosemite, compojure is latest master.
› lein bikeshed
Checking for lines longer than 80 characters.
Badly formatted files:
/Users/aroche/Code/clj/compojure/test/compojure/core_test.clj:174: request (mock/request :get "/ip/0%3A0%3A0%3A0%3A0%3A0%3A0%3A1%250") ]
/Users/aroche/Code/clj/compojure/test/compojure/response_test.clj:53: (is (= (get-in response [:headers "Content-Length"]) (str (count body-str))))
Checking for lines with trailing whitespace.
No lines found.
Checking for files ending in blank lines.
No files found.
Checking for redefined var roots in source directories.
No with-redefs found.
Checking whether you keep up with your docstrings.
25/42 [59.52%] functions have docstrings.
Use -v to list functions without docstrings
Subprocess failed
cc @weavejester
Unlike https://github.com/jonase/eastwood/issues/88, this looks like a legitimate warning, not an exception.
The “subprocess failed” part?
The "subprocess failed" part is because lein-bikeshed calls (System/exit -1) if the bikeshed check fails.
I just fixed the problems identified by bikeshed. Now it reports this error. Strange.
Checking for arguments colliding with clojure.core functions.
Subprocess failed
It sounds like it's because you have some arguments colliding with core function names.
But it's a bit weird that there is no other output than that
Yeah, it should have output similar to:
Checking for arguments colliding with clojure.core functions.
#'clj-http.client/coerce-transit-form-params: 'type' is colliding with a core function
#'clj-http.client/content-type-value: 'type' is colliding with a core function
#'clj-http.client/parse-transit: 'type' is colliding with a core function
#'clj-http.client/coerce-json-body: 'keyword?' is colliding with a core function
#'clj-http.client/coerce-transit-body: 'type' is colliding with a core function
#'clj-http.client/transit-encode: 'type' is colliding with a core function
#'clj-http.core/set-client-param: 'key', 'val' are colliding with core functions
#'clj-http.headers/assoc-join: 'name' is colliding with a core function
Subprocess failed
I'll see if I can reproduce it on compojure, @xpe do you have a particular SHA that it reproduces with?
Was there any more info on this? I'm seeing same error, but no compojure (though library does use core.async). Rest of output shows nothing concerning (except low docstring %!).