cheshire icon indicating copy to clipboard operation
cheshire copied to clipboard

Refactor internal functions to use opts map

Open gfredericks opened this issue 10 years ago • 2 comments

Many internal functions had two or three arguments for customizing behavior. Since we'd like to be able to add more customization in the future, condensing these into an options map seems like a good move.

One subtle difference introduced is that the functions which previously read a :date-format value from a map and used or to determine whether to used the default-date-format, now use merge and so have different behavior if the :date-format key is present but nil. I'm assuming this will be fine.

gfredericks avatar Sep 19 '15 19:09 gfredericks

This is of course w.r.t. #77.

gfredericks avatar Sep 19 '15 19:09 gfredericks

Okay, so having a child has unfortunately sucked up a lot of my time for open source projects, so let's improve the community!

@gfredericks I've added you as a contributor to the project, if you want to merge this (run the benchmarks first please!) that would be great! I'll continue to help with issues but I don't want to be a blocker :)

dakrone avatar Oct 12 '15 23:10 dakrone