fzfs icon indicating copy to clipboard operation
fzfs copied to clipboard

audioop removed in Python 3.13

Open gwuen opened this issue 10 months ago • 2 comments

As the title says, audioop was removed with Python 3.13 after being deprecated in Python 3.11. It is currently only used in the BLE mode. There's a community-maintained LTS version that might serve as a replacement: https://pypi.org/project/audioop-lts/

gwuen avatar Feb 05 '25 12:02 gwuen

Why the heck do I even need audioop...

dakhnod avatar Feb 05 '25 12:02 dakhnod

True. I was wondering about that too, but then again, I have really no idea how this Bluetooth stuff is implemented.

On another note, nis was also removed in Python 3.13. This is used in the protobuf bindings, and initially I thought I had to report this upstream, but it seems like it's already fixed there. You probably only have to update the submodule to a more recent commit.

gwuen avatar Feb 05 '25 12:02 gwuen

Heyo, I updated the dependencies. Could you both please try again?

dakhnod avatar Sep 03 '25 10:09 dakhnod

Unfortunately, I can't seem to get the Bluetooth connection working, but this is probably an unrelated problem. The change looks good to me!

The flipperzero_protobuf_py submodule still needs a version bump though (because of nis). I have already tested this, it shouldn't require any more changes in fzfs.

gwuen avatar Sep 04 '25 00:09 gwuen

ah, good call on protobuf, thanks!

dakhnod avatar Sep 04 '25 10:09 dakhnod

@gwuen Okay, I updated the protobuf dependency. Could you please test?

dakhnod avatar Sep 04 '25 11:09 dakhnod

Works as expected :)

Only numpy wouldn't build (because of numpy/numpy#23808), bumping to 1.26.4 fixes this. numpy2 might also work, but latest 1.x release seems fine for now.

I'd suggest bumping all dependencies to the latest versions at some point to be on the safe side for the next two Python releases or so. I can also take a look at that and open a PR after testing.

gwuen avatar Sep 04 '25 12:09 gwuen

I just ran pip install numpy and expected that to be the latest version. Apparently I did something wrong...

A PR would be welcome, thanks

dakhnod avatar Sep 04 '25 12:09 dakhnod