Cloud-Platform
Cloud-Platform copied to clipboard
Live Editor is not using latest FontAwesome
Describe the bug When editing custom screens in the live editor, the Fonts Awesome Fonts being used are on v6 and are outdated. This results in some deviation of display between the end device display.
To Reproduce Steps to reproduce the behavior:
- Create custom screen.
- Add block to custom screen that will use icons, this can be a calendar with icons entered, or a homeassistant block/ fetch block with icons added.
- Note that icons rendered in the live editor layout have differences in style with the the preview function, and end device used.
Expected behavior Live editor should be using latest Fonts Awesome Fonts available.
Screenshots N/A
Desktop (please complete the following information):
- N/A
Smartphone (please complete the following information):
- N/A
Additional context Identified in client case 38578.
We will need to take some further consideration for this. The new version of FontAwesome tracks each page-load, and we're limited to 1M/month. If we update the screens to use this, we may very well go over 1M. At the very least we will need to monitor usage. If/when we go over the limit, we can self-host the fontawesome files on static.dakboard.com.
All associated icon selectors and live editor will be moved to FA 5.15 to be made consistent with the actual DAKboard screens.
- v6 Kit loads are counted as page loads, not individual icon usages
- v6 Kit loads in the code appear only in options and screen-layout-editor layouts
- v6 font family is only set on
.checkbox
styled items
Given these, we have turned off all kit loads, reinstated the v5 links and reverted Font Awesome 6 Pro
references to 5
.
Merged in @ 09ac20a and added to the queue for upcoming release to the live site.